Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prism]: Fix unknown coder urn key: beam:coder:nullable:v1 #31340

Merged
merged 1 commit into from
May 20, 2024
Merged

[Prism]: Fix unknown coder urn key: beam:coder:nullable:v1 #31340

merged 1 commit into from
May 20, 2024

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented May 18, 2024 •
edited
Loading

This PR fixes #31336. I performed the following to validate this change:

  1. Run Prism server.
./gradlew :runners:prism:runServer
  1. Execute :runners:portability:java:ulrLoopbackValidatesRunnerTests on Prism:
TEST=org.apache.beam.sdk.transforms.CombineFnsTest
./gradlew :runners:portability:java:ulrLoopbackValidatesRunnerTests -PjobEndpoint=localhost:8073 --tests="$TEST"

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review May 18, 2024 00:48
@github-actions GitHub Actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

lostluck
lostluck approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit fed6489 into apache:master May 20, 2024
6 checks passed
@damondouglas damondouglas deleted the prism-fix-unknown-nullable-coder branch May 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostluck lostluck lostluck approved these changes

Assignees
No one assigned
Labels
go Next Action: Reviewers runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][Prism]: panic: unknown coder urn key: beam:coder:nullable:v1
2 participants
@damondouglas @lostluck